Fix incorrect design of handlers (Frequency, RunningAverage, etc.) #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdesrozis
changed the title
vfdev-5
reviewed
Jan 22, 2021
sdesrozis
changed the title
|
@sdesrozis thanks for the update! I was thinking as Checkpoint and ModelCheckpoint fix is the most simple and we do not break other things, it would be better to do it in a separate PR. For others, I'm not yet sure about the fix to adopt. |
|
Ok so if I understand correctly, I do a new PR with last commits about ModelCheckpoint fix, right ? And let's see for others ? |
|
Exactly! |
3 tasks
|
To be honest currently I'm not that sure about introducing things in this way. Let's try to find a better design that you already told previously about... I'd prefer to keep things as is instead of introducing a half-good solution. What do you think ? |
|
Not relevant at the moment. I prefer close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1405
Description:
Frequency: introduction of a specific usageFrequencyWiseto fit theMetric.attach()api.Check list: